ci: upgrade Node.js 20 → 22 in squad-standard-lint-markdown#423
Merged
Conversation
markdownlint-cli2 0.23.0 and markdownlint 0.41.0 now require Node.js >= 22. Update the workflow runner to match. Relates to #420 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… initializers Aspire 13.3.5 requires Arguments as a required member. Tests now initialize with empty array [] to satisfy the compiler constraint CS9035. - MongoClearDataIntegrationTests: Added Arguments = [] - MongoSeedDataIntegrationTests: Added Arguments = [] - MongoShowStatsIntegrationTests: Added Arguments = [] Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
the
squad
🏗️ PR Added to Squad Triage QueueThis PR has been labeled with Next steps:
|
- .github/dependabot.yml: Remove spaces in brackets [ "*" ] → ["*"] - .github/workflows/add-issues-to-project.yml: Split long GraphQL mutation and break long error message line - .github/workflows/blog-readme-sync.yml: Split long regex pattern and extract link pattern to variable for readability Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- .copilot/skills/git-workflow/SKILL.md: Add bash/text language specs - .copilot/skills/model-selection/SKILL.md: Add bash/json language specs - .copilot/skills/pre-push-test-gate/SKILL.md: Add bash language specs - .copilot/skills/personal-squad/SKILL.md: Add bash language specs - .copilot/skills/mongodb-filter-pattern/SKILL.md: Add csharp/bash language specs - .copilot/skills/auth0-token-forwarding/SKILL.md: Add csharp/xml language specs - .copilot/skills/cli-wiring/SKILL.md: Add bash/csharp language specs - .github/agents/squad.agent.md: Add language specs to all code blocks Fixes MD040 (missing language specs) markdown linting errors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates CI configuration to use Node.js 22 for the markdown lint workflow (to meet newer markdownlint toolchain requirements) and also adjusts a few AppHost MongoDB integration tests to populate a new/required ExecuteCommandContext.Arguments field.
Changes:
- Update
.github/workflows/squad-standard-lint-markdown.ymlto useactions/setup-nodewith Node.js 22. - Update AppHost MongoDB integration tests to initialize
ExecuteCommandContext.Argumentswith an empty collection.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/squad-standard-lint-markdown.yml |
Bumps Node.js version from 20 → 22 for the markdown lint workflow. |
tests/AppHost.Tests/MongoShowStatsIntegrationTests.cs |
Initializes ExecuteCommandContext.Arguments to an empty collection in test helper context creation. |
tests/AppHost.Tests/MongoSeedDataIntegrationTests.cs |
Initializes ExecuteCommandContext.Arguments to an empty collection in test helper context creation. |
tests/AppHost.Tests/MongoClearDataIntegrationTests.cs |
Initializes ExecuteCommandContext.Arguments to an empty collection in test helper context creation. |
Comment on lines
152
to
+156
| ResourceName = "mongodb", | ||
| ServiceProvider = new ServiceCollection().BuildServiceProvider(), | ||
| Logger = NullLogger.Instance, | ||
| CancellationToken = TestContext.Current.CancellationToken, | ||
| Arguments = [], |
- squad-standard-lint-yaml.yml: Remove trailing blank line - squad-dependabot-auto-merge.yml: Remove trailing blank line - squad-main-from-dev-guard.yml: Remove trailing blank line - squad-standard-lint-markdown.yml: Remove trailing blank line Fixes empty-lines yamllint errors. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
markdownlint-cli2 0.23.0 (bumped in #420) and markdownlint 0.41.0 now require Node.js >= 22. The
squad-standard-lint-markdown.ymlworkflow was pinned to Node 20, which would fail once the new devDependencies are installed locally.Changes
.github/workflows/squad-standard-lint-markdown.yml:node-version: "20"→node-version: "22"Notes
lint-markdown.ymlusesmarkdownlint-cli2-action@v23(GitHub Action, nosetup-nodeneeded) — no change required there.MessagePackNU1902/NU1903) are a pre-existing issue unrelated to the npm bump.Closes #420 (companion workflow fix)
Working as Boromir (DevOps)